Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: disallow get raw vector data of a BM25 Function output field #37800

Merged
merged 1 commit into from
Nov 20, 2024
Merged

enhance: disallow get raw vector data of a BM25 Function output field #37800

merged 1 commit into from
Nov 20, 2024

Conversation

zhengbuqian
Copy link
Collaborator

issue: #35853

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Nov 19, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Nov 19, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@buqian-zilliz buqian-zilliz force-pushed the doc-in-disallow-get-vector branch from 581dbf4 to d60ccd6 Compare November 19, 2024 05:28
@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

@codecov Codecov
Copy link

codecov bot commented Nov 19, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.02%. Comparing base (5a23c80) to head (b361962).
Report is 51 commits behind head on master.

Files with missing lines Patch % Lines
pkg/util/typeutil/schema.go 88.88% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #37800      +/-   ##
==========================================
+ Coverage   80.67%   81.02%   +0.34%     
==========================================
  Files        1357     1357              
  Lines      190679   190032     -647     
==========================================
+ Hits       153835   153965     +130     
+ Misses      31416    30605     -811     
- Partials     5428     5462      +34
Components Coverage Δ
Client 72.16% <ø> (+10.90%) ⬆️
Core 68.87% <ø> (-0.06%) ⬇️
Go 83.19% <95.00%> (+<0.01%) ⬆️
Files with missing lines Coverage Δ
internal/proxy/meta_cache.go 90.72% <100.00%> (+0.54%) ⬆️
internal/proxy/util.go 89.80% <100.00%> (+0.01%) ⬆️
pkg/util/typeutil/schema.go 85.23% <88.88%> (+0.22%) ⬆️

... and 114 files with indirect coverage changes

---- 🚨 Try these New Features:

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

@czs007
Copy link
Collaborator

czs007 commented Nov 19, 2024

/approve
/lgtm

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

@mergify Mergify
Copy link
Contributor

mergify bot commented Nov 19, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@buqian-zilliz buqian-zilliz force-pushed the doc-in-disallow-get-vector branch from d60ccd6 to b361962 Compare November 19, 2024 11:52
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added the ci-passed label Nov 20, 2024
@czs007
Copy link
Collaborator

czs007 commented Nov 20, 2024

/lgtm

@sre-ci-robot sre-ci-robot merged commit 511edd2 into milvus-io:master Nov 20, 2024
19 of 20 checks passed
@zhengbuqian zhengbuqian deleted the doc-in-disallow-get-vector branch November 20, 2024 06:23
JsDove pushed a commit to JsDove/milvus that referenced this pull request Nov 26, 2024
@zhengbuqian @JsDove
enhance: disallow get raw vector data of a BM25 Function output field (…
349b68c 
…milvus-io#37800)

issue: milvus-io#35853

Signed-off-by: Buqian Zheng <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czs007 czs007 Awaiting requested review from czs007

@godchen0212 godchen0212 Awaiting requested review from godchen0212

Assignees

@czs007 czs007

Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zhengbuqian @czs007 @sre-ci-robot